Skip to content

ci: let Dependabot pull requests skip the description template - #7

Merged
panicDa3m0n merged 1 commit into
mainfrom
ci/dependabot-template-exemption
Oct 20, 2026
Merged

panicDa3m0n merged 1 commit into
mainfrom
ci/dependabot-template-exemption

Conversation

@panicDa3m0n

Copy link
Copy Markdown
Owner

What

The Conventions check skips the description template for pull requests opened by Dependabot (dependabot[bot], account type Bot). Their title is still checked as Conventional Commits, and every other check runs as before. CONTRIBUTING.md mentions the exemption.

Why

Dependabot writes its own description, so Conventions failed every update it opened (#2: sections What, Tested and Checklist missing). With Conventions required on main, those updates could never be merged. Usernames cannot contain brackets, so no person can claim the exemption.

Tested

  • New tests in tools/tests/test_check_conventions_pr_template.py, driven through a GitHub event file:
    • a Dependabot pull request passes;
    • its title is still checked;
    • the same description fails for a user, for a user named like the bot, for another bot and for a missing user.
  • Deliberate mistakes, each caught by the tests:
    • exempt everyone;
    • exempt no one;
    • match the name only, without the account type;
    • skip the title check.
  • The real event of ci: bump actions/github-script from 8.0.0 to 9.0.0 in the actions group across 1 directory #2: the checker on main reports the 3 template errors seen in CI; the changed checker passes it.
  • python tools/check_conventions.py --base main: all checks passed. The checker's unit tests pass on Windows.

Checklist

  • One topic, based on current main
  • Code follows docs/dev/CONVENTIONS.md; unimplemented paths throw
  • Generic behaviour, not specific to one title
  • Performance change: behind an APS5_NO_* switch, documented in docs/dev/ENVIRONMENT.md, with a test that fails on a deliberate mistake
  • No game files, executables, dumps or frame captures in the repository or in this pull request
  • Depends on: none
  • Fixes: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

Dependabot writes its own pull request description, so the Conventions check failed every update it opened. A pull request whose author is dependabot[bot] with the Bot account type now skips the template check; its title is still checked as Conventional Commits. Usernames cannot contain brackets, so no person can claim the exemption. The tests cover Dependabot, the same description from other authors (a user, a user named like the bot, another bot, no user) and a non-conventional Dependabot title.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T14:13:27.964940Z b0aae97 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@panicDa3m0n
panicDa3m0n merged commit 7c60bc5 into main Oct 20, 2026
4 checks passed
@panicDa3m0n
panicDa3m0n deleted the ci/dependabot-template-exemption branch October 20, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant